Skip to content

fix(import-map): add support for import maps in user workers #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 31, 2025
Merged

fix(import-map): add support for import maps in user workers #626

merged 5 commits into from
Oct 31, 2025

Conversation

@0x5457
Copy link
Contributor

@0x5457 0x5457 commented Oct 22, 2025

What kind of change does this PR introduce?

Bug fix - Fixes import map support in user workers

What is the current behavior?

fixes #621

@0x5457 0x5457 force-pushed the fix/import-map branch 3 times, most recently from 36d65bd to 7985aa7 Compare October 22, 2025 12:22
@nyannyacha
Copy link
Contributor

nyannyacha commented Oct 30, 2025

Hey @0x5457 , I'm quickly looking this over right now 😋

I think we can merge it once we fix a few things.
Would it be okay if I modify your branch to make the merge faster?

nyannyacha
nyannyacha reviewed Oct 30, 2025
View reviewed changes
@nyannyacha
Copy link
Contributor

nyannyacha commented Oct 30, 2025

Plus, as you also specified in the description, this PR should be classified as a fix/enhancement.
When merging this commit, I will use fix instead of the feat prefix.

@nyannyacha nyannyacha changed the title feat(import-map): add support for import maps in user workers fix(import-map): add support for import maps in user workers Oct 30, 2025
@nyannyacha
Copy link
Contributor

nyannyacha commented Oct 30, 2025

(PR title has been changed)
@0x5457

@nyannyacha
Copy link
Contributor

nyannyacha commented Oct 31, 2025 •
edited
Loading

0x5457 force-pushed the fix/import-map branch from bda9b46 to 5fdd60d

nyannyacha force-pushed the fix/import-map branch from 5fdd60d to 76eb42f

😂

@nyannyacha
Copy link
Contributor

nyannyacha commented Oct 31, 2025

You probably resolved the no_npm test conflict that occurred in integration_tests.rs too, right?
Since we resolved the same thing, it shouldn't matter.

nyannyacha
nyannyacha approved these changes Oct 31, 2025
View reviewed changes
Copy link
Contributor

@nyannyacha nyannyacha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😺
Thank you for catching this and patiently pushing it forward until it was merged!

@nyannyacha nyannyacha merged commit a174612 into supabase:main Oct 31, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nyannyacha nyannyacha nyannyacha approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Import map not being applied to user workers

2 participants

@0x5457 @nyannyacha